<html>
<head><meta charset="utf-8"><title>cherry-pick some LLVM patches · t-compiler/wg-llvm · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/index.html">t-compiler/wg-llvm</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/cherry-pick.20some.20LLVM.20patches.html">cherry-pick some LLVM patches</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="212697788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/cherry-pick%20some%20LLVM%20patches/near/212697788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/cherry-pick.20some.20LLVM.20patches.html#212697788">(Oct 08 2020 at 14:28)</a>:</h4>
<p>as we are discussing on <a class="stream-topic" data-stream-id="238009" href="/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.20meeting.5D.202020-10-08.20.2354818">#t-compiler/meetings &gt; [weekly meeting] 2020-10-08 #54818</a> I was wondering how is the process we follow to cherry-pick LLVM patches</p>



<a name="212697795"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/cherry-pick%20some%20LLVM%20patches/near/212697795" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/cherry-pick.20some.20LLVM.20patches.html#212697795">(Oct 08 2020 at 14:28)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116122">@simulacrum</span></p>



<a name="212697877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/cherry-pick%20some%20LLVM%20patches/near/212697877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/cherry-pick.20some.20LLVM.20patches.html#212697877">(Oct 08 2020 at 14:29)</a>:</h4>
<p>That's a <span class="user-mention" data-user-id="138448">@cuviper</span> or <span class="user-mention" data-user-id="133224">@Nikita Popov</span> question, I think</p>



<a name="212697896"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/cherry-pick%20some%20LLVM%20patches/near/212697896" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/cherry-pick.20some.20LLVM.20patches.html#212697896">(Oct 08 2020 at 14:29)</a>:</h4>
<p>for instance <a href="https://github.com/rust-lang/rust/issues/76387">#76387</a> is opened waiting for the LLVM to get into LLVM code base and then we can cherry-pick it</p>



<a name="212697927"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/cherry-pick%20some%20LLVM%20patches/near/212697927" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/cherry-pick.20some.20LLVM.20patches.html#212697927">(Oct 08 2020 at 14:29)</a>:</h4>
<p>but I wonder how do we track that so we can close the issue at some point</p>



<a name="212698808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187780-t-compiler/wg-llvm/topic/cherry-pick%20some%20LLVM%20patches/near/212698808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nikita Popov <a href="https://rust-lang.github.io/zulip_archive/stream/187780-t-compiler/wg-llvm/topic/cherry-pick.20some.20LLVM.20patches.html#212698808">(Oct 08 2020 at 14:35)</a>:</h4>
<p>The process is basically to open a PR with the cherry-pick on <a href="https://github.com/rust-lang/llvm-project">https://github.com/rust-lang/llvm-project</a> and then update the submodule. As long as the commit is already in upstream LLVM and fixes a miscompile (and is not just a new optimization) it should always get accepted.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>